[Content] Create item modal UX updates #3525
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen clicking create without selecting a model
finnar-bin
added
enhancement
There was a problem hiding this comment.
Pull Request Overview
This PR updates the create item modal UX by adding autofocus behavior, removing the "None" default option, always enabling the create button, and incorporating error handling when no model is selected.
- Removes default "None" option from the selected model
- Adds error handling to alert the user when no model is selected
- Implements autofocus and open-on-focus features for improved UX
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/shell/components/CreateContentItemDialog.tsx | Adjusts state initialization, error handling, and autocomplete behavior for model selection |
| cypress/e2e/content/navigation.spec.js | Adds tests to verify error handling and modal behavior with no model selection |
geodem127
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3356
Content---Zesty-io---zesty-pw---Manager.1.webm