Skip to content

[#3353]: Content: Multi Page Table - Skeleton Loading Screen #3423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 30 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
dd1711b
Add error handling on load instance (#3359)
agalin920 Apr 7, 2025
64bcf9e
Merge remote-tracking branch 'refs/remotes/origin/dev' into dev
geodem127 Apr 16, 2025
124dfb6
Merge remote-tracking branch 'refs/remotes/origin/dev' into dev
geodem127 Apr 17, 2025
b8ca839
Merge remote-tracking branch 'refs/remotes/origin/dev' into dev
geodem127 Apr 17, 2025
76f6da8
Merge remote-tracking branch 'refs/remotes/origin/dev' into dev
geodem127 Apr 19, 2025
e4596df
Merge remote-tracking branch 'refs/remotes/origin/dev' into dev
geodem127 Apr 23, 2025
73f677d
Merge remote-tracking branch 'refs/remotes/origin/dev' into dev
geodem127 Apr 24, 2025
427d914
Merge remote-tracking branch 'refs/remotes/origin/dev' into dev
geodem127 Apr 26, 2025
f6a90dd
Merge remote-tracking branch 'refs/remotes/origin/dev' into dev
geodem127 Apr 29, 2025
706e272
Merge remote-tracking branch 'refs/remotes/origin/dev' into dev
geodem127 Apr 30, 2025
c6d2e20
Merge remote-tracking branch 'refs/remotes/origin/dev' into dev
geodem127 May 5, 2025
e991fba
Merge remote-tracking branch 'refs/remotes/origin/dev' into dev
geodem127 May 5, 2025
e6c04a9
Merge remote-tracking branch 'refs/remotes/origin/dev' into dev
geodem127 May 6, 2025
f6d8198
Merge remote-tracking branch 'refs/remotes/origin/dev' into dev
geodem127 May 7, 2025
b99979b
Merge remote-tracking branch 'refs/remotes/origin/dev' into dev
geodem127 May 8, 2025
7ff8c32
Merge remote-tracking branch 'refs/remotes/origin/dev' into dev
geodem127 May 9, 2025
bbcf45c
Merge remote-tracking branch 'refs/remotes/origin/dev' into dev
geodem127 May 9, 2025
3bd2bdd
INIT
geodem127 Apr 30, 2025
beb2ad6
fix column with issue when refreshed
geodem127 May 1, 2025
c08f2b8
Fixed conflicts
geodem127 May 12, 2025
0351757
updated loading dependencies
geodem127 May 15, 2025
e2014a3
Merge remote-tracking branch 'refs/remotes/origin/dev' into dev
geodem127 May 15, 2025
dfe2aa6
Merge remote-tracking branch 'refs/remotes/origin/dev' into dev
geodem127 May 18, 2025
a9bd782
Merge remote-tracking branch 'refs/remotes/origin/dev' into dev
geodem127 May 18, 2025
09c2a62
Merge remote-tracking branch 'refs/remotes/origin/dev' into dev
geodem127 May 19, 2025
3c0cae8
Merge remote-tracking branch 'refs/remotes/origin/dev' into dev
geodem127 May 19, 2025
892b460
Merge remote-tracking branch 'refs/remotes/origin/dev' into dev
geodem127 May 22, 2025
0407dd3
Merge remote-tracking branch 'refs/remotes/origin/dev' into dev
geodem127 May 23, 2025
e4e3d7c
Merge branch 'dev' into feature/3353-Content-Multi-Page-Table-Skeleto…
geodem127 May 23, 2025
facb3e1
relocated CellGridSkeletonCell component in Shell's foleder
geodem127 May 24, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
99 changes: 58 additions & 41 deletions src/apps/content-editor/src/app/views/ItemList/ItemListTable.tsx
Original file line number Diff line number Diff line change
@@ -1,23 +1,10 @@
import { useHistory, useParams as useRouterParams } from "react-router";
import {
Box,
CircularProgress,
Chip,
Typography,
Link,
Checkbox,
Stack,
} from "@mui/material";
import { ImageRounded } from "@mui/icons-material";
import { useGetContentModelFieldsQuery } from "../../../../../../shell/services/instance";
import { Box, Typography, Link, Checkbox } from "@mui/material";
import {
DataGridPro,
GridRenderCellParams,
GRID_CHECKBOX_SELECTION_COL_DEF,
useGridApiRef,
GridInitialState,
GridComparatorFn,
GridPinnedColumns,
} from "@mui/x-data-grid-pro";
import {
memo,
Expand All @@ -28,7 +15,10 @@ import {
useContext,
} from "react";
import AutoSizer, { Size } from "react-virtualized-auto-sizer";
import { ContentItem } from "../../../../../../shell/services/types";
import {
ContentItem,
ContentModelField,
} from "../../../../../../shell/services/types";
import { useStagedChanges } from "./StagedChangesContext";
import { OneToManyCell } from "./TableCells/OneToManyCell";
import { UserCell } from "./TableCells/UserCell";
Expand All @@ -41,12 +31,15 @@ import { currencies } from "../../../../../../shell/components/FieldTypeCurrency
import { Currency } from "../../../../../../shell/components/FieldTypeCurrency/currencies";
import { ImageCell } from "./TableCells/ImageCell";
import { SingleRelationshipCell } from "./TableCells/SingleRelationshipCell";
import { useParams } from "../../../../../../shell/hooks/useParams";
import { TableSortContext } from "./TableSortProvider";
import { FIELD_SKELETON_MAP, gridLoadingStyles } from "./Loader";
import { Skeleton } from "@mui/material";
import DataGridSkeletonCell from "../../../../../../shell/components/DataGridSkeletonCell";

type ItemListTableProps = {
loading: boolean;
rows: ContentItem[];
fields: ContentModelField[];
noRowsOverlay: () => JSX.Element;
};

Expand Down Expand Up @@ -265,7 +258,7 @@ const fieldTypeColumnConfigMap = {
} as const;

export const ItemListTable = memo(
({ loading, rows, noRowsOverlay }: ItemListTableProps) => {
({ loading, rows, fields, noRowsOverlay }: ItemListTableProps) => {
const { modelZUID } = useRouterParams<{ modelZUID: string }>();
const apiRef = useGridApiRef();
const [initialState, setInitialState] = useState<GridInitialState>();
Expand All @@ -275,8 +268,6 @@ export const ItemListTable = memo(
const [sortModel, setSortModel] = useContext(TableSortContext);
const [pinnedColumns, setPinnedColumns] = useState({});

const { data: fields } = useGetContentModelFieldsQuery(modelZUID);

const saveSnapshot = useCallback(() => {
if (apiRef?.current && localStorage) {
const currentState = apiRef.current.exportState();
Expand Down Expand Up @@ -319,13 +310,19 @@ export const ItemListTable = memo(
}, [saveSnapshot, fields, modelZUID]);

const columns = useMemo(() => {
const gridState = localStorage?.getItem(`${modelZUID}-dataGridState`);
const colDimensions = gridState
? JSON.parse(gridState)?.columns?.dimensions
: null;

let result: any[] = [
{
field: "version",
headerName: "Vers.",
width: 64,
sortable: true,
filterable: false,
cellClassName: "version",
renderCell: (params: GridRenderCellParams) => (
<VersionCell params={params} />
),
Expand All @@ -340,6 +337,7 @@ export const ItemListTable = memo(
field: field.name,
headerName: field.label,
filterable: false,
cellClassName: field?.datatype,
valueGetter: (params: any, row: any) => {
if (field.datatype === "currency") {
return {
Expand All @@ -360,29 +358,32 @@ export const ItemListTable = memo(
})),
];
}
return [...result, ...METADATA_COLUMNS];
}, [fields]);

if (!initialState) {
return (
<Box
display="flex"
justifyContent="center"
alignItems="center"
height="100%"
>
<CircularProgress />
</Box>
);
}
result = [
...result,
...METADATA_COLUMNS?.map((column) => ({
...column,
cellClassName: column.field,
flex: !fields?.length ? 1 : 0,
})),
];
return result.map((column) => {
const { headerName, ...other } = column;
return {
...other,
width: colDimensions?.[column.field]?.width || column.width,
renderHeader: () =>
loading ? FIELD_SKELETON_MAP.header : headerName,
};
});
}, [fields, loading]);

return (
<AutoSizer>
{({ width, height }: Size) => (
<DataGridPro
apiRef={apiRef}
loading={loading}
rows={rows}
rows={loading ? [] : rows}
columns={columns}
style={{
width,
Expand Down Expand Up @@ -413,12 +414,18 @@ export const ItemListTable = memo(
}}
slots={{
noRowsOverlay: noRowsOverlay,
baseCheckbox: (props: any) => (
<Checkbox
disabled={stagedChanges && Object.keys(stagedChanges)?.length}
{...props}
/>
),
baseCheckbox: (props: any) =>
loading ? (
<Skeleton variant="rounded" width="18px" height="18px" />
) : (
<Checkbox
disabled={
stagedChanges && Object.keys(stagedChanges)?.length
}
{...props}
/>
),
skeletonCell: DataGridSkeletonCell,
}}
slotProps={{
baseTooltip: {
Expand All @@ -436,6 +443,10 @@ export const ItemListTable = memo(
},
},
},
loadingOverlay: {
variant: "skeleton",
noRowsVariant: "skeleton",
},
}}
getRowClassName={(params) => {
// if included in staged changes, highlight the row
Expand Down Expand Up @@ -473,6 +484,7 @@ export const ItemListTable = memo(
params.row?.meta?.version &&
!(stagedChanges && Object.keys(stagedChanges)?.length)
}
onColumnWidthChange={saveSnapshot}
sx={{
backgroundColor: "common.white",
".MuiDataGrid-row": {
Expand Down Expand Up @@ -515,6 +527,11 @@ export const ItemListTable = memo(
"& [data-cy='NoResults']": {
pointerEvents: "all",
},
"& .MuiDataGrid-row.MuiDataGrid-rowSkeleton": {
borderBottom: "1px solid",
borderColor: "border",
},
...(loading ? gridLoadingStyles : {}),
}}
/>
)}
Expand Down
Loading
Loading