fix: add tests and better error for dynamic imports #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #30
In order to support dynamic imports and implement
importModuleDynamically
, we have to use vm.SourceModuleText which is still experimental and only available behind--experimental-vm-modules
flag. Yet current situation might be super confusing especially when users are not directly usingv8-compile-cache
and see a clueless error like this:After this PR: (git.io link redirects to #30)
I would be happy to also help in the future with the actual implementation of the VM cache 😊