New Feature: zmqpp::message template #163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed message to message_base and redefined message to `typedef message_base<std::vector> message` to avoid breaking the current API. This commit is to allow the ability of changing the container without changing the base class. Currently, it only supports `std::vector` and `std::deque`.
Solution: Clean up unwanted changes.
|
This is in response to #162, I also forgot to mention that I added a |
|
message_base would probably be better named like the std library way of doing templates with default behavior so basic_ which would make it basic_message which would become typedef basic_message<std::vector> message; |
…C++ std library standard naming convention.
|
This is giving me lots of errors locally, I will try and find time to check it and work through it but my free time for the next month is looking pretty bad sorry :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this is to allow interchangability of the base container of zmqpp::message. Currently, the only supported containers are
std::vector(Its original) andstd::deque.P.S. Sorry for making message.hpp 700+ lines long (XD) and exposing the implementation. I couldn't find a way to keep the member functions out of the header. If someone could figure that out, I would love to hear it.
P.S.S. This is my first time creating templates on a large scale, I would not be surprised if I made a mistake or two, but I did test it on both ends of compilation, to make sure it worked as before. (Windows only)
Edit: It also didn't affect compile time as much as I was expecting.