Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorg endpoint, fix flaky test, fix Host Ipv6 parse and display #76

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Reorg endpoint, fix flaky test, fix Host Ipv6 parse and display #76

merged 2 commits into from
Oct 6, 2020

Conversation

TheButlah
Copy link
Contributor

@TheButlah TheButlah commented Oct 4, 2020

I'm trying to break up #72 to be a bit smaller, so I've manually extracted some of the changes from there to this separate PR.

This PR reorganizes the endpoint module to break it up into a few submodules. This helps readability and makes it easier to navigate that code.

I've also fixed some issues with how endpoints and hosts displayed and parsed IPV6 addresses. I've reworked the semantics of Host::Ipv6 to more closely match the semantics of std::net::Ipv6Addr, and added associated tests. This removes the need for the format!("{}:{}", host, port) that I was doing whenever I passed a host and port tuple to tokio, and correspondingly fixes the bugs in the parts of the code that weren't using that.

I also fixed a flaky test - as mentioned in #73, our sockets are not yet resistant to ordering issues when connecting to an endpoint that might not yet be bound. For this reason, we now await until the pub socket has finished binding in the pub_sub test

@TheButlah TheButlah changed the title Reorg endpoint fix flaky test improve host parse and display Reorg endpoint, fix flaky test, improve host parse and display Oct 4, 2020
@TheButlah TheButlah changed the title Reorg endpoint, fix flaky test, improve host parse and display Reorg endpoint, fix flaky test, fix Host Ipv6 parse and display Oct 4, 2020
@Alexei-Kornienko Alexei-Kornienko merged commit 9eb060f into zeromq:master Oct 6, 2020
@TheButlah TheButlah deleted the reorg-endpoint-fix-flaky-test-improve-host-parse-and-display branch October 7, 2020 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants