Code

Poller.remove socket disposed fix#835

Code

Open

jasells wants to merge 33 commits intozeromq:masterzeromq/netmq:masterfrom jasells:Poller.Remove-SocketDisposed-Fixjasells/netmq:Poller.Remove-SocketDisposed-FixCopy head branch name to clipboard

+442-21

Commits

Commits on Dec 3, 2019

• added NetMQPollerTest.RemoveAndDisposeSocket() as a repro for issue zeromq#834

  jasells

  committed
  3b8dbb9

Commits on Dec 4, 2019

• Task refactor of .Remove(ISocketPollable) passes test!

  jasells

  committed
  d0f2725

• speed up the test a little

  jasells

  committed
  53e1833

• async fix supporting .NET40, broke a test

  jasells

  committed
  68429d7

Commits on Dec 8, 2019

• un-break the API back to sycnronous (but now working)

  jasells

  committed
  dea90f4

• rename new test to avoid confusion

  jasells

  committed
  6b344ca

• fixed RemoveAndDispose()

  jasells

  committed
  c879804

• fix other Remove methods

  jasells

  committed
  54c2931

• clean up the RUn method for .NET40 compat

  jasells

  committed
  bc362a9

• undo changes in RemoveThrowsIfSocketAlreadyDisposed

  jasells

  committed
  98a0f00

• fixing spacing complaints

  jasells

  committed
  a3819e1

Commits on Dec 21, 2019

• return task from tests

  jasells

  committed
  4f3b1e6

• fixing wait() calls

  jasells

  committed
  33816cb

• use Task.Factory.StartNew

  jasells

  committed
  bda8b3f

Commits on Feb 18, 2020

• initial refactor works, except for one test.

  jasells

  committed
  cb16939

• fix Selector to handle disposed sockets

  jasells

  committed
  544bb94

• added comment about previous commmit

  jasells

  committed
  87b7649

• removed comment

  jasells

  committed
  92163b1

• fix region tag formatting

  jasells

  committed
  51457d1

Commits on Feb 29, 2020

• sync with master

  jasells

  committed
  fce2bb0

• updated comments

  jasells

  committed
  38910d8

• cleaer names for async socket remove tests

  jasells

  committed
  3bacfb8

• I believe this should address the net45/net40 Task.FromResult() concern

  jasells

  committed
  455f6b0

Commits on Mar 31, 2020

• ensure tasks are queued on the poller, not the task pool.

  jasells

  committed
  52fa20e

• remove the dictionary checks.

  jasells

  committed
  884d4ea

• fix indentation

  jasells

  committed
  9f17258

Commits on Apr 7, 2020

• removed comment that needs seperate PR

  jasells

  committed
  3ea0693

Commits on Apr 24, 2020

• added RemoveAsync(Socket ) overload

  jasells

  committed
  72ebdbc

• comment update

  jasells

  committed
  c14f9f9

• added REmoveASync(timer) overload and test

  jasells

  committed
  0a767c6

• fix depricated message

  jasells

  committed
  fa5e49b

• refactored ContainsAsync() methods

  jasells

  committed
  83a34b6

• added doc block

  jasells

  committed
  217e4f4