-
Notifications
You must be signed in to change notification settings - Fork 7
feat(token-app)t: implement ZBanc token trading functionality with form validation and error handling #3374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
domw30
wants to merge
17
commits into
main
Choose a base branch
from
feat/implement-ZBanc-token-trading-functionality-with-form-validation-and-error-handling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m validation and error handling
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…lity-with-form-validation-and-error-handling
…lity-with-form-validation-and-error-handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
We're adding a complete trading interface that allows users to buy/sell ZBanc tokens through deposit/mint and redeem/withdraw operations, including form validation, real-time price calculations, loading states, and error handling.
Why are we making this change?
We're implementing this to enable users to trade ZBanc tokens directly within the zOS frontend, providing a seamless trading experience with proper validation to prevent invalid transactions and clear feedback for all trading states.
How do I test this?
Run tests as usual
Key decisions and Risk Assessment:
Things to consider: