drivers: ethernet: xmc4xxx: Fixes the checksum of bridged packets #99428
+132
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
ClaCodes,
decsny,
lmajewski,
maass-hamburg,
mcatee-infineon,
pdgendt,
sreeramIfx and
talih0
Due to checksum offloading, the checksum field of a packet must be zero before sending it to packet to the ethernet controller, otherwise the computed checksum will be incorrect. If the packet is bridged, it already has the correct checksum in place, which will cause the automatically computed checksum to incorrectly become zero. In this patch we give bridged packets the special attention they need. Signed-off-by: Marcelo Roberto Jimenez <[email protected]>
mrjimenez
force-pushed
the
fix_checksum_bridge
branch
from
e9ef7b0 to
925e8e9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to checksum offloading, the checksum field of a packet must be zero before sending it to packet to the ethernet controller, otherwise the computed checksum will be incorrect.
If the packet is bridged, it already has the correct checksum in place, which will cause the automatically computed checksum to incorrectly become zero.
In this patch we give bridged packets the special attention they need.