Clock separation test #95270
Closed
Clock separation test #95270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
platform: WE
area: Clock Control
platform: Seeed Studio
zephyrbot
requested review from
aescolar,
anangl,
greg-leach,
hubertmis,
jaz1-nordic,
kl-cruz,
magp-nordic,
mah-eiSmart,
masz-nordic,
nika-nordic,
nordic-krch,
rerickson1 and
wm-eisos
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-hal_nordic
DNM (manifest)
greg-leach
reviewed
Sep 2, 2025
Comment on lines
+329
to
+339
| config CLOCK_CONTROL_NRF_HFCLK | ||
| bool "NRF HFCLK driver support" | ||
| depends on DT_HAS_NORDIC_NRF_CLOCK_HFCLK_ENABLED | ||
| select CLOCK_CONTROL_NRF_COMMON | ||
| default y | ||
|
|
||
| config CLOCK_CONTROL_NRF_XO | ||
| bool "NRF XO driver support" | ||
| depends on DT_HAS_NORDIC_NRF_CLOCK_XO_ENABLED | ||
| select CLOCK_CONTROL_NRF_COMMON | ||
| default y |
There was a problem hiding this comment.
Formatting looks awry here (but may be rendering issue in Github).
greg-leach
reviewed
Sep 2, 2025
Comment on lines
+15
to
+24
| #if NRFX_CHECK(NRFX_POWER_ENABLED) | ||
| nrfx_power_irq_handler(); | ||
| #endif | ||
|
|
||
| STRUCT_SECTION_FOREACH(clock_control_nrf_irq_handler, irq) { | ||
| irq->handler(); | ||
| } | ||
|
|
||
| /* temporary fix, it will be removed when all the clocks are moved to their files */ | ||
| nrfx_clock_irq_handler(); |
There was a problem hiding this comment.
Similar formatting issue here.
greg-leach
reviewed
Sep 2, 2025
| .handler = _a, \ | ||
| } | ||
|
|
||
| void clock_control_nrf_common_connect_irq( void ); |
There was a problem hiding this comment.
Extra spaces around argument.
greg-leach
reviewed
Sep 2, 2025
Comment on lines
+209
to
+211
| /* Check needed due to anomaly 201: | ||
| * HFCLKSTARTED may be generated twice. | ||
| */ |
greg-leach
reviewed
Sep 2, 2025
| @@ -0,0 +1,407 @@ | |||
| #include <soc.h> | |||
greg-leach
previously approved these changes
Sep 2, 2025
mif1-nordic
force-pushed
the
clock_separation_test
branch
2 times, most recently
from
bee829d to
043d569
Compare
Separated clock_control_nrf_hfclk shim from clock_control_nrf shim. Signed-off-by: Michal Frankiewicz <[email protected]>
Separated clock_control_nrf_xo shim from clock_control_nrf shim. Signed-off-by: Michal Frankiewicz <[email protected]>
Separated clock_control_nrf_lfclk shim from clock_control_nrf shim. Signed-off-by: Michal Frankiewicz <[email protected]>
mif1-nordic
force-pushed
the
clock_separation_test
branch
3 times, most recently
from
52f74d5 to
aee41c5
Compare
Updated west to have nrfx driver clock separation PR. Signed-off-by: Michal Frankiewicz <[email protected]>
mif1-nordic
force-pushed
the
clock_separation_test
branch
from
aee41c5 to
1a46985
Compare
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.