bluetooth: hci: userchan: Guard reads from going over frame-sz #89029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubieda
changed the title
github-actions
bot
added
area: Bluetooth HCI
github-actions
bot
requested review from
alwa-nordic,
cvinayak,
hermabe,
HoZHel,
jhedberg,
sjanc,
Thalley and
theob-pro
ubieda
force-pushed
the
fix/cid-487679-userchan-buf-overflow
branch
from
495bcdc to
71141c2
Compare
Even though through code-inspection there isn't a clear path where the guard wouldn't act upon the length reaching the limit, this check is moved up to unconditially validate it on every read. Fixes zephyrproject-rtos#84731. Signed-off-by: Luis Ubieda <[email protected]>
ubieda
force-pushed
the
fix/cid-487679-userchan-buf-overflow
branch
from
71141c2 to
f002629
Compare
ubieda
changed the title
jhedberg
approved these changes
Apr 24, 2025
Thalley
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though through code-inspection there isn't a clear path where the guard wouldn't act upon the length reaching the limit, this check is moved up to unconditially validate it on every read.
Fixes #84731.