watchdog: cmsdk_apb: handle non-secure watchdog #89025
Open
+48
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CMSDK watchdog driver is currently not handling the non-secure watchdog interrupt. This commit adds the necessary code to handle the non-secure interrupt and ensure that the watchdog timer is properly managed in both secure and non-secure modes. Signed-off-by: Oscar Wu <[email protected]>
|
Closed the previous PR as it was messed up during the sync and rebase process, which unintentionally introduced hundreds of commits into the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original CMSDK Watchdog driver assumes that the watchdog triggers an NMI. However, when the TrustZone security extension is implemented, a non-secure variant of the watchdog timer is instantiated, which raises a separate interrupt instead.
Since the secure watchdog raises a combined NMI and does not require an interrupts property in the DTS, whereas the non-secure one does, it seems reasonable to use this distinction to determine which instance is being referenced.
This proposed pull request updates the driver to support such configurations, enabling successful execution of the following test cases:
Platform: Atmosic ATM34
Core: ARM Cortex-M33F
ZTEST passed:
tests/drivers/watchdog/wdt_basic_api
tests/drivers/watchdog/wdt_basic_reset_none