boards: nordic: devicetree file cleanup #89017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This configuration is for a system that has been removed Signed-off-by: Jamie McCrae <[email protected]>
This configuration is for a system that has been removed Signed-off-by: Jamie McCrae <[email protected]>
This configuration is for a system that has been removed Signed-off-by: Jamie McCrae <[email protected]>
This configuration is for a system that has been removed Signed-off-by: Jamie McCrae <[email protected]>
github-actions
bot
added
platform: Ezurio
platform: nRF
github-actions
bot
requested review from
anangl,
greg-leach,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic,
nika-nordic and
rerickson1
greg-leach
reviewed
Apr 24, 2025
| @@ -37,17 +37,20 @@ | |||
|
|
|||
| leds { | |||
| compatible = "gpio-leds"; | |||
|
|
|||
| /* Lightwell RGB */ | |||
| led0: led_0 { | |||
| gpios = <&sx1509b 7 GPIO_ACTIVE_LOW>; | |||
| label = "Red LED"; | |||
| //vin-supply = <&vdd_pwr>; | |||
There was a problem hiding this comment.
(//vin-supply . . . piece).
There was a problem hiding this comment.
Seems added by a 5 year old commit to signify that the power from the LEDs is coming from vdd_pwr as part of the sx1509b I/O expander, assuming just as a comment to indicate, but no explicit reason to keep it
greg-leach
previously approved these changes
Apr 24, 2025
Fixes issues to make files compliant with the Zephyr devicetree guidelines Signed-off-by: Jamie McCrae <[email protected]>
Removes the scratch area from the network core for this board target, this was not used anyhow but gets rid of a configuration that would use a non-optimal swap mode Signed-off-by: Jamie McCrae <[email protected]>
greg-leach
approved these changes
Apr 24, 2025
anangl
approved these changes
Apr 24, 2025
rerickson1
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes files compliant with zephyr devicetree guidelines