soc: espressif: esp32c6: Add LP_CORE support #84092
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
andyross,
dcpleung,
decsny,
galak,
jukkar,
kartben,
marekmatej,
nashif,
nordic-krch,
raffarost,
rruuaanng,
sylvioalves,
teburd,
uLipe and
wmrsouza
LucasTambor
force-pushed
the
esp32c6/lp_core
branch
from
49723e7 to
d03f5f3
Compare
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_espressif
DNM
LucasTambor
force-pushed
the
esp32c6/lp_core
branch
2 times, most recently
from
f798daf to
4be9e15
Compare
|
Please split the commits: one for SoC changes, one for board, and one for each test. |
LucasTambor
force-pushed
the
esp32c6/lp_core
branch
from
4be9e15 to
62d04da
Compare
@dcpleung Wouldn't that affect bisectability? This PR doesn’t just add a new target; it also modifies an existing one. |
LucasTambor
force-pushed
the
esp32c6/lp_core
branch
2 times, most recently
from
ac7625c to
e58acc7
Compare
sylvioalves
reviewed
Feb 5, 2025
sylvioalves
reviewed
Feb 5, 2025
sylvioalves
reviewed
Feb 5, 2025
sylvioalves
reviewed
Feb 5, 2025
sylvioalves
reviewed
Feb 5, 2025
sylvioalves
reviewed
Feb 5, 2025
marekmatej
requested changes
Feb 5, 2025
LucasTambor
force-pushed
the
esp32c6/lp_core
branch
from
7759633 to
c7ddd51
Compare
LucasTambor
force-pushed
the
esp32c6/lp_core
branch
4 times, most recently
from
e53d8a2 to
b17bb78
Compare
sylvioalves
reviewed
Feb 12, 2025
sylvioalves
reviewed
Feb 12, 2025
sylvioalves
reviewed
Feb 12, 2025
sylvioalves
reviewed
Feb 12, 2025
sylvioalves
reviewed
Feb 12, 2025
Add ULP Coprocessor support for ESP32C6. Signed-off-by: Lucas Tamborrino <[email protected]>
LucasTambor
force-pushed
the
esp32c6/lp_core
branch
from
b17bb78 to
3df3f5a
Compare
sylvioalves
previously approved these changes
Feb 12, 2025
wmrsouza
previously approved these changes
Feb 12, 2025
Add ULP Coprocessor board support for C6. This requires a change in the board qualifier depending on the build target. Update esp32c6 overlay and configuration files to the proper name. Signed-off-by: Lucas Tamborrino <[email protected]>
Add ULP directory for samples related to the Ultra Low Power Coprocessor. Add a sample to demonstrate the debug process of the LP Core Signed-off-by: Lucas Tamborrino <[email protected]>
LucasTambor
dismissed stale reviews from wmrsouza and sylvioalves
via
e9e4c0d
LucasTambor
force-pushed
the
esp32c6/lp_core
branch
from
3df3f5a to
e9e4c0d
Compare
marekmatej
reviewed
Feb 12, 2025
| @@ -162,7 +162,7 @@ manifest: | |||
| groups: | |||
| - hal | |||
| - name: hal_espressif | |||
| revision: fbbe8f22f34cadc43b69f9eb3fca10e301874e36 | |||
There was a problem hiding this comment.
as a good practice, I suggest moving manifest changes as a first commit or part of the first commit.
There was a problem hiding this comment.
That would mess with bissectability, changes in HAL are valid from this commit forward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires a change in the board qualifier depending on the build
target.