Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2440 - Support PHP 8.4 #2441

Merged
merged 31 commits into from
Jan 27, 2025
Merged

#2440 - Support PHP 8.4 #2441

merged 31 commits into from
Jan 27, 2025

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Nov 23, 2024

Hello!

  • Type: bug fix | new feature | code quality | documentation
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of change:

Thanks

@Jeckerson Jeckerson self-assigned this Nov 23, 2024
@Jeckerson Jeckerson changed the title #2440 php84 #2440 - Support PHP 8.4 Nov 23, 2024
@Jeckerson Jeckerson linked an issue Dec 2, 2024 that may be closed by this pull request
@Jeckerson
Copy link
Member Author

@Girgias Could you know why it happens in PHP8.4?

/home/runner/work/zephir/zephir/ext/kernel/object.c:1233:20: error: static declaration of ‘object_init_with_constructor’ follows non-static declaration
   1233 | static zend_result object_init_with_constructor(zval *arg, zend_class_entry *class_type, uint32_t param_count, zval *params, HashTable *named_params)
        |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
  In file included from /usr/include/php/20240924/main/php.h:36,
                   from /home/runner/work/zephir/zephir/ext/kernel/object.c:16:

https://github.com/zephir-lang/zephir/actions/runs/12985306565/job/36209905121?pr=2441#step:6:474

@Girgias
Copy link
Contributor

Girgias commented Jan 27, 2025

Hum, I guess the linker is trying to use the version I defined instead of the Zend one, let me send a PR.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 7.36196% with 151 lines in your changes missing coverage. Please review.

Project coverage is 5.51%. Comparing base (1afe9d3) to head (599cd40).
Report is 32 commits behind head on development.

Additional details and impacted files
@@              Coverage Diff               @@
##           development   #2441      +/-   ##
==============================================
+ Coverage             0   5.51%   +5.51%     
==============================================
  Files                0     282     +282     
  Lines                0   25494   +25494     
==============================================
+ Hits                 0    1406    +1406     
- Misses               0   24088   +24088     

@Jeckerson Jeckerson requested a review from niden January 27, 2025 14:04
@Jeckerson Jeckerson marked this pull request as ready for review January 27, 2025 14:04
@Jeckerson Jeckerson merged commit c3cbbb6 into development Jan 27, 2025
56 checks passed
@Jeckerson Jeckerson deleted the #2440-php84 branch January 27, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.4 support
3 participants