fix: revert adding PersistManager::findBy() #996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
force-pushed
the
fix/bug-with-ulid
branch
from
398e900 to
519aee9
Compare
nikophil
force-pushed
the
fix/bug-with-ulid
branch
from
519aee9 to
94d9899
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #990 by actually reverting #983 - this solution implied too much problems (see #992 and #994), and I don't know how to fix #990 without too much complexity.
I fixed the problem it initially tried to resolve by forcing the refresh of the entities returned by the repository decorator which are already tracked. This increases the number of SQL requests, but it simplifies a lot the code (and we actually do not perform more sql queries than we used to with proxies)
The good side of this is that few more tests cases were added to the testsuite 😊