fix: should not use flush_after() in FactoryCollection::create()

[nikophil]

this reproduces both #907 and #911 and fixes them (two issue, same fix) - @phasdev did add a feature flag for flush once, but the bug still remains.

flush_after() was definitely not a good idea in FactoryCollection::create(): "flush once" behavior should not be a hard requirement, and something like findOrCreate() should actually flush.

thanks again to @phasdev, the reproducers were very helpful!

fixes #907 fixes #911

[Copilot]

Pull Request Overview

Reproduces and fixes issues #907 and #911 by adjusting flush behavior when using findOrCreate() inside createMany(), replacing flush_after() in core logic and adding robust tests.

• Added integration tests covering findOrCreate() in bulk creation and ensuring inverse relationships are hydrated before flush.
• Changed the persistence layer’s save() to accept multiple objects and flush in one operation.
• Refactored FactoryCollection::create() to use the new multi-object save() instead of the flush_after() helper.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
tests/Integration/ORM/EntityRelationship/EntityFactoryRelationshipTestCase.php	New test cases for bulk findOrCreate() and flush_after() behavior
src/Persistence/functions.php	Updated save() helper to delegate to the new persistence API
src/Persistence/PersistenceManager.php	Expanded save() to accept variadic objects and flush appropriately
src/FactoryCollection.php	Removed flush_after() usage in create() in favor of direct saves

Comments suppressed due to low confidence (1)

src/Persistence/functions.php:122

• Consider adding or updating the docblock above this helper to explain that it now always returns the original object (the underlying persistence manager no longer returns the entity).

function save(object $object): object

[nikophil]

I don't know what's happening in this PR: seg fault in codecov, paratest which takes forever... 🤷

EDIT : OK I know why, that's because of data providers

[smnandre]

🌹

[nikophil]

@smnandre does this fixes the problem you told me about?

[smnandre]

Pretty sure, i'll test friday

[kbond]

Awesome, thanks everyone!

@smnandre be sure to let us know if this doesn't fix your issue.

[smnandre]

I will, trust me 😆

[nikophil]

this was released in 2.5.3 🙂

[smnandre]

Not conclusive... we still have something weird with clear and collections, but it's more and more probable recent changes in Foundry simply exposed a bug that was already here in our code