Skip to content

feat: Introduce #[AsFixture] attribute and foundry:load-fixture command #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 0 commits into from
May 12, 2025

Conversation

nikophil
Copy link
Member

@nikophil nikophil commented May 11, 2025

fixes #898

⚠️ I made a mistake with git, follow up in #903

@nikophil nikophil changed the title feat/load story command feat: Introduce #[AsFixture] attribute and foundry:load-fixture command May 11, 2025
@nikophil nikophil force-pushed the feat/load-story-command branch from fb32008 to 1d0840f Compare May 11, 2025 19:31
@nikophil nikophil force-pushed the feat/load-story-command branch from 1d0840f to 7273b0b Compare May 11, 2025 19:38
@nikophil nikophil force-pushed the feat/load-story-command branch 4 times, most recently from 5d28972 to ce36ee1 Compare May 11, 2025 20:08
@nikophil nikophil requested a review from kbond May 11, 2025 20:09
@nikophil nikophil force-pushed the feat/load-story-command branch from ce36ee1 to fb569fe Compare May 11, 2025 20:15
@nikophil nikophil force-pushed the feat/load-story-command branch from fb569fe to cf83d55 Compare May 12, 2025 08:34
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

From a DX perspective, I'd really like:

  1. When you install foundry, the recipe creates an AppStory (like the doctrine-fixtures recipe does)
  2. Just run bin/console foundry:load-stories (no arguments)

So, what do you think about: if you pass the command no args and there's only one services tagged #[AsFixture], load that one?

@nikophil
Copy link
Member Author

From a DX perspective, I'd really like:

  • When you install foundry, the recipe creates an AppStory (like the doctrine-fixtures recipe does)
  • run bin/console foundry:load-stories (no arguments)

So, what do you think about: if you pass the command no args and there's only one services tagged #[AsFixture], load that one?

💯

@nikophil nikophil merged commit cf83d55 into zenstruck:2.5.x May 12, 2025
73 of 74 checks passed
@nikophil nikophil deleted the feat/load-story-command branch May 12, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants