Skip to content

Comments

Develop#511

Merged
zeng407 merged 6 commits intomasterfrom
develop
Feb 14, 2026
Merged

Develop#511
zeng407 merged 6 commits intomasterfrom
develop

Conversation

@zeng407
Copy link
Owner

@zeng407 zeng407 commented Feb 14, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 14, 2026 08:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR centralizes page-specific script injection by adding a Blade scripts stack in the main layout, and refactors multiple ad-related Blade partials/pages to push their scripts into that stack (plus a small accessibility improvement in the game view).

Changes:

  • Add @stack('scripts') to layouts/app.blade.php so views/partials can use @push('scripts').
  • Move several ad script blocks (Google GPT / OneAD / Adsense loader) into the scripts stack and adjust their loading behavior.
  • Update game element preview image alt bindings to use the element title.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
resources/views/layouts/app.blade.php Adds @stack('scripts') near </body> to support stacked script injection.
resources/views/home.blade.php Pushes Google GPT setup and ad-slot display scripts into the scripts stack.
resources/views/game/show.blade.php Improves image accessibility by binding alt to element titles.
resources/views/game/rank.blade.php Adds GPT anchor ad setup to the rank page header.
resources/views/ads/script_load_ad.blade.php Pushes Adsense loader script into the scripts stack and wraps with DOMContentLoaded.
resources/views/ads/rank_onead_2.blade.php Refactors OneAD script loading into stacked scripts and dynamic script insertion.
resources/views/ads/rank_onead_1.blade.php Refactors OneAD script loading into stacked scripts and dynamic script insertion.
resources/views/ads/onead_text.blade.php Refactors OneAD text-drive script loading into stacked scripts and dynamic script insertion.
resources/views/ads/home_onead_2_pc.blade.php Refactors OneAD native-drive script loading into stacked scripts and dynamic script insertion.
resources/views/ads/home_onead_1_pc.blade.php Refactors OneAD fullscreen script loading into stacked scripts and dynamic script insertion.
resources/views/ads/game_onead_1_pc.blade.php Refactors OneAD script loading into stacked scripts (but currently has a broken Blade directive).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zeng407 zeng407 merged commit 2962c6d into master Feb 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant