feat: implement refund service (#165)#196
Open
OSEH-svg wants to merge 1 commit intozendvolabs:mainfrom
Open
Conversation
|
@OSEH-svg Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #165
Description
This PR addresses issue #165 by implementing the specialized
refundServiceand updating thetransactionServiceto properly handle refund triggers when a gift goes into a rejected or failed state.The refund logic now correctly caters to:
processRefundTransactionmethod safely located within thetransactionService.ts.All changes adhere strictly to the existing file structure without touching any non-explicitly listed files (maintaining the
giftStatusEnumschema constraints by standardizing on exactly representing rejection endpoints as"failed").Changes Made
src/server/services/refundService.ts: Introduced theprocessRefundservice method to direct refunds based onpaymentProviderorigin properties.src/server/services/transactionService.ts: AddedprocessRefundTransactionto cleanly and accurately deduct ledger funds from recipients and apply them back to senders.Verification
src/server/services/refundService.ts&src/server/services/transactionService.ts).