fix: Shift navbar down when accesing it on macOS in fullscreen (#8757) #9865
Conversation
dosubot
bot
added
size:M
| + // : ""; | ||
| + const padding = shiftSize > 0 ? `${shiftSize}px` : ""; | ||
| + const appContentNavbarWrapper = document.getElementById('zen-appcontent-navbar-wrapper'); | ||
| + appContentNavbarWrapper.style.paddingTop = gURLBar.textbox.hasAttribute("breakout") |
There was a problem hiding this comment.
Shoudnt we check if it's double toolbar as well?
There was a problem hiding this comment.
Good point, I didn't consider that case, I'll do some tests and try to add it
There was a problem hiding this comment.
I wonder if instead of this fullscreen we can just not hide it at all, like what chromium browsers do.
There was a problem hiding this comment.
You mean like not showing the macOS title bar that shifts down at all? That could work, the window minimize, maximize and close buttons would be lost and should be moved to the toolbar though.
As it is, this fix takes the same solution that firefox did, but I agree the chromium way is more simple. I'll try experimenting to see if I can replicate it.
There was a problem hiding this comment.
Has this check been done? Im not sure where that is
|
Can you please merge this, its painful to work with Zen on full screen on compact mode. |
mr-cheffy
left a comment
mr-cheffy
left a comment
There was a problem hiding this comment.
@npinochet could you please resolve git conflicts so it can get merged into twilight?
|
|
npinochet
force-pushed
the
dev
branch
2 times, most recently
from
d480a11 to
6111cf1
Compare
|
Any issues still in this PR ? |
3 participants
Shift nav bar down when accessing it on macOS while in fullscreen, allowing it to be shown when the macOS top bar appears.
I tried to keep this PR simple, but the nav bar kept auto hiding when the macOS top bar appears making it difficult to access. The changes made in
ZenCompactMode.mjsfixes that.Fixes #8757
EDIT: This is how it currently works
https://github.com/user-attachments/assets/5ad31673-366a-4c65-b6ba-2d2b2a2036ff