Fix: Persist favicons for pinned tabs and migrate existing pins (#9389) #11363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves pinned tab handling so favicon data is stored and reused Adds DB column for icon data and prefers saved icons over recomputing Introduces lazy migration and async capture to backfill missing favicons Adds temporary debug logging to trace favicon load and storage paths
Removes verbose debug logging around pinned tab favicon handling Uses stored data URIs directly for original icon styling
dosubot
bot
added
size:L
dosubot
bot
added
size:XL
dosubot
bot
added
size:L
Contributor
Author
|
There are a lot of ways to reproduce the issue #9389. @mr-cheffy but I'm not too sure if the way i went about fixing it is the best solution. If you have any qualms about it. Let me know. I know a lot of people are waiting for this bug to get fixed. |
Member
|
I dont think this is the best way to tackle the issue tbh, but anyways, we are removing this implementation with window sync. #10034 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9389
Persists favicon data for pinned tabs by storing base64 data URIs in the database. This ensures favicons are preserved across browser restarts and workspace changes.
Changes:
icon_datacolumn to store favicon data URIsMigration:
Existing pinned tabs without favicons are automatically migrated in the background after initialization, prioritizing essential pins.