-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: add basic vim navigation to urlbar #10518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Could there please be some unit tests about this to make sure future firefox versions dont break this functionality? |
@mr-cheffy I've gone ahead and written a unit test for the vim navigation feature. It's a little crude, so let me know if you have a better way to force multiple possible selections in the URLBar more reliably. What I've done works, but I'm afraid it might be a little brittle, so I'll leave it up to your judgement. |
300e97c
to
19e0f1a
Compare
Rebased to fix conflicts, is there anything else that needs to be done in this PR before it can get reviewed? |
This reverts commit 382a38c.
Will keep this in about:config but removing clutter from the Preferences page
Updated the PR to remove the option from Preferences to keep it just in about:config, removed the localization since that was only used for the Preferences checkbox, and added the test for when the about:config option is turned off. |
Adds the keybinds ctrl+j and ctrl+k to down and up respectively when the urlbar is active for making selections.
This change adds:
Tested on MacOS and Ubuntu (Parallels)
Behavior we see:
zen-urlbar-vim-navigation-1080.mov