Skip to content

fix libfmt compiler warnings with GCC 14 #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Henny022p wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −2
Open

fix libfmt compiler warnings with GCC 14 #700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05ddbd6
bump libfmt to 11.0.2 to fix compiler warnings with g++ 14
Henny022p Mar 3, 2025
cb1f00c
"fix" false positive null pointer dereference warning
Henny022p Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ FetchContent_Declare(
FetchContent_Declare(
fmt
GIT_REPOSITORY https://github.com/fmtlib/fmt.git
GIT_TAG 8.0.1
GIT_TAG 11.0.2
)
# CLI11
FetchContent_Declare(
Expand Down
7 changes: 6 additions & 1 deletion tools/src/asset_processor/assets/frameobjlists.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,12 @@ void FrameObjListsAsset::convertToHumanReadable(const std::vector<char>& baserom
fmt::print(file.get(), "\t.4byte {:#x}\n", pointer);
}

u32 max_second_level = *std::max_element(second_level.begin(), second_level.end());
auto max_second_level_it = std::max_element(second_level.begin(), second_level.end());
if (max_second_level_it == second_level.end()) {
fmt::print(stderr, "no second level (unreachable)");
exit(1);
}
u32 max_second_level = *max_second_level_it;

while (reader.cursor < size) {
if (static_cast<u32>(reader.cursor) > max_second_level) {
Expand Down