docs: align test DSL doc with current integration_test_lib interfaces

[Fibonacci747]

Update test DSL documentation in docs/test_dsl_spec.md to reflect the actual interfaces in src/lib/testing/integration_test_lib/intf.ml. The prior document described a design-phase DSL with primitives like spawn, destroy, task, stop, collect, and a multi-flag wait_for, which are not present in the current code. The DSL now operates in the Malleable_error.t context, provides section/section_hard, uses wait_for : t -> Wait_condition.t -> unit Malleable_error.t with explicit Wait_condition constructors and with_timeouts, and surfaces log error accumulation helpers. This change prevents misleading guidance, aligns examples and signatures conceptually with the implemented architecture using Engine, Network_manager, Event_router, and Network_state, and adds a disclaimer indicating that existing pseudo-code reflects an earlier design and should be translated to the current model.

[gemini-code-assist]

Summary of Changes

Hello @Fibonacci747, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on bringing the test DSL documentation up-to-date with the actual implementation of the integration_test_lib. By removing outdated design concepts and accurately describing the current interfaces, the PR aims to provide clear and correct guidance for developers writing integration tests, ensuring that the documentation reflects the operational architecture and prevents misleading information.

Highlights

• Documentation Alignment: The documentation for the test DSL (docs/test_dsl_spec.md) has been updated to accurately reflect the current integration_test_lib interfaces, removing outdated design-phase primitives.
• Updated DSL Primitives: Outdated primitives like spawn, destroy, task, stop, assert, and collect have been removed from the documentation, as they are no longer part of the current DSL surface.
• New section and wait_for Interfaces: The section function now operates within the Malleable_error.t context, and a section_hard variant has been added. The wait_for function has been updated to use explicit Wait_condition.t constructors and with_timeouts.
• Log Error Accumulation: New helpers for log error accumulation, watch_log_errors and lift_accumulated_log_errors, have been surfaced and documented.
• Pseudo-code Disclaimer: A disclaimer has been added to the pseudo-code examples, indicating that they reflect an earlier design and need to be translated to the current model using Engine.Network_manager/Engine.Network for orchestration.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request provides a much-needed update to the test DSL documentation, aligning it with the current implementation. The changes are clear and significantly improve the documentation's accuracy by removing outdated primitives and introducing the new Malleable_error.t-based DSL features. The addition of a note about the outdated examples is also a crucial clarification for users. I have a couple of minor suggestions to further enhance the document's clarity, but overall, this is an excellent and valuable contribution.

[gemini-code-assist]

The type t in this function signature is not defined in this document. To improve clarity for readers, it would be helpful to add a brief explanation of what t represents (e.g., the test runner state). You could add a comment in the code block or a sentence in the description.

[gemini-code-assist]

This note is very important for preventing users from trying to use outdated examples. To make it more prominent and ensure it's not missed, consider using a blockquote and bolding the 'Note' label.

Suggested change

	Note: The following examples reflect an earlier design proposal and do not match the current DSL API. They should be translated to use `Engine.Network_manager`/`Engine.Network` for orchestration and `Dsl.wait_for` with `Wait_condition` for synchronization.
	> **Note**: The following examples reflect an earlier design proposal and do not match the current DSL API. They should be translated to use `Engine.Network_manager`/`Engine.Network` for orchestration and `Dsl.wait_for` with `Wait_condition` for synchronization.