Skip to content

Conversation

@vitallium
Copy link
Contributor

Hi, this is a follow-up change for #41754 I think it important to keep existing things working. So add notes to the Ruby extension doc about enabling Ruby LSP for ERB files as well. Thanks!

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Nov 3, 2025
"Ruby": {
"language_servers": ["ruby-lsp", "!solargraph", "!rubocop", "..."]
},
// Enable herb and ruby-lsp for *.html.erb files
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

herb is enabled by default for *.html.erb.

},
// Enable herb and ruby-lsp for *.html.erb files
"HTML+ERB": {
"language_servers": ["herb", "ruby-lsp", "..."]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the note above, I think we could leave it as ["ruby-lsp", "..."] but I want to show that we explicitly enable both herb and ruby-lsp.

@vitallium
Copy link
Contributor Author

/cc @marcoroth

@marcoroth
Copy link
Contributor

Dumb question: does it hurt to keep ruby-lsp enabled by default for any *.erb file, so people don't have to opt-in?

@vitallium
Copy link
Contributor Author

Dumb question: does it hurt to keep ruby-lsp enabled by default for any *.erb file, so people don't have to opt-in?

In some way, yes, it does. Zed uses solargraph by default and the Ruby extension has some open issues (1, 2) where users wonder why they have ruby-lsp enabled even they have it disabled explicitly in their settings.

Adding a requirement in enabling ruby-lsp for ERB files explicitly is not ideal, I agree. Hopefully, the situation will improve once extensions have more control over language server configurations for files.

@osiewicz osiewicz merged commit 11b29d6 into zed-industries:main Nov 5, 2025
25 checks passed
maxbrunsfeld pushed a commit that referenced this pull request Nov 6, 2025
Hi, this is a follow-up change for
#41754 I think it important to
keep existing things working. So add notes to the Ruby extension doc
about enabling Ruby LSP for ERB files as well. Thanks!

Release Notes:

- N/A
maxbrunsfeld pushed a commit that referenced this pull request Nov 6, 2025
Hi, this is a follow-up change for
#41754 I think it important to
keep existing things working. So add notes to the Ruby extension doc
about enabling Ruby LSP for ERB files as well. Thanks!

Release Notes:

- N/A
tomatitito pushed a commit to tomatitito/zed that referenced this pull request Nov 7, 2025
…41851)

Hi, this is a follow-up change for
zed-industries#41754 I think it important to
keep existing things working. So add notes to the Ruby extension doc
about enabling Ruby LSP for ERB files as well. Thanks!

Release Notes:

- N/A
@vitallium vitallium deleted the vs/doc-ruby-lsp-enable-erb branch November 18, 2025 06:18
11happy pushed a commit to 11happy/zed that referenced this pull request Dec 1, 2025
…41851)

Hi, this is a follow-up change for
zed-industries#41754 I think it important to
keep existing things working. So add notes to the Ruby extension doc
about enabling Ruby LSP for ERB files as well. Thanks!

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement community champion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants