-
Notifications
You must be signed in to change notification settings - Fork 6.3k
ruby: Add note about enabling Ruby LSP for ERB files #41851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ruby: Add note about enabling Ruby LSP for ERB files #41851
Conversation
| "Ruby": { | ||
| "language_servers": ["ruby-lsp", "!solargraph", "!rubocop", "..."] | ||
| }, | ||
| // Enable herb and ruby-lsp for *.html.erb files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
herb is enabled by default for *.html.erb.
| }, | ||
| // Enable herb and ruby-lsp for *.html.erb files | ||
| "HTML+ERB": { | ||
| "language_servers": ["herb", "ruby-lsp", "..."] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the note above, I think we could leave it as ["ruby-lsp", "..."] but I want to show that we explicitly enable both herb and ruby-lsp.
|
/cc @marcoroth |
|
Dumb question: does it hurt to keep |
In some way, yes, it does. Zed uses Adding a requirement in enabling |
Hi, this is a follow-up change for #41754 I think it important to keep existing things working. So add notes to the Ruby extension doc about enabling Ruby LSP for ERB files as well. Thanks! Release Notes: - N/A
Hi, this is a follow-up change for #41754 I think it important to keep existing things working. So add notes to the Ruby extension doc about enabling Ruby LSP for ERB files as well. Thanks! Release Notes: - N/A
…41851) Hi, this is a follow-up change for zed-industries#41754 I think it important to keep existing things working. So add notes to the Ruby extension doc about enabling Ruby LSP for ERB files as well. Thanks! Release Notes: - N/A
…41851) Hi, this is a follow-up change for zed-industries#41754 I think it important to keep existing things working. So add notes to the Ruby extension doc about enabling Ruby LSP for ERB files as well. Thanks! Release Notes: - N/A
Hi, this is a follow-up change for #41754 I think it important to keep existing things working. So add notes to the Ruby extension doc about enabling Ruby LSP for ERB files as well. Thanks!
Release Notes: