fix(make): colorize targets from imported make-files #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old behavior use to parse the content of the invoked `Makefile` unit to define targets. Such parsing didn't take into account targets from unit imported by the current (ex: targets defined in files imported such as `import ./targets/help.mk`). New behavior pass the content of the Makefile unit post lexing (aka `make -f Makefile -pn` instead of the plain unit.
pschmitt
reviewed
Jun 25, 2025
7 tasks
burgesQ
added a commit
to burgesQ/fast-syntax-highlighting
that referenced
this pull request
Jul 16, 2025
…um#81) * fix(make): colorize targets from imported make-files Old behavior use to parse the content of the invoked `Makefile` unit to define targets. Such parsing didn't take into account targets from unit imported by the current (ex: targets defined in files imported such as `import ./targets/help.mk`). New behavior pass the content of the Makefile unit post lexing (aka `make -f Makefile -pn` instead of the plain unit. * Update →chroma/-make.ch --------- Co-authored-by: Philipp Schmitt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Old behavior use to parse the content of the invoked
Makefileunit to define targets.Such parsing didn't take into account targets from unit imported by the current (ex: targets defined in files imported such as
import ./targets/help.mk).New behavior pass the content of the Makefile unit post lexing (aka
make -f Makefile -pninstead of the plain unit.Related Issue(s)
No issue created but I could open one if needed
Motivation and Context
My makefiles unit heavily rely on the
includekeyword to DRY up my monorepo. As such, targets defined in included makefile unit arn't recognize by the makefile chroma.Usage examples
How Has This Been Tested?
Types of changes
Checklist: