[ZIP 173] Bech32 Format #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daira
added
Sapling
daira
force-pushed
the
zip-0173
branch
2 times, most recently
from
bf17bc0 to
7007355
Compare
str4d
reviewed
Feb 22, 2019
zip-0173.rst
Outdated
Collaborator
There was a problem hiding this comment.
Why are we re-specifying Bech32? AFAIK Zcash-Bech32 is identical to Bitcoin-Bech32 except that the hard length limit is raised from 90 to 1024.
Can we not just refer to BIP 173 for the specification of Bech32, and then specify the Zcash differences and consensus-rule effects here? That seems like it would be significantly easier to both write and reason about.
Collaborator
Author
There was a problem hiding this comment.
If you read BIP 173, there are quite a few things it says that are just plain wrong or inapplicable for Zcash. The ZIP fixes those.
Collaborator
There was a problem hiding this comment.
ACK. Le sigh. Puts on reviewing goggles
daira
force-pushed
the
master
branch
15 times, most recently
from
4864dde to
c333fe2
Compare
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daira Hopwood daira@jacaranda.org