-
Notifications
You must be signed in to change notification settings - Fork 33
appender for AWS kinesis streams #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
added code to pipeline data with AWR library into the AWS kinesis streams: https://github.com/daroczig/AWR.Kinesis
R/appender.R
Outdated
| { | ||
|
|
||
| function(line) { | ||
| library(AWR.Kinesis) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requireNamespace might be more appropriate here? And maybe adding to Suggests in the DESCRIPTION file.
|
Hi thanks for the contribution. The |
|
As the author and maintainer of Note that it has been also added to To keep it short, I'd suggest reworking this PR to use the |
added code to pipeline data with AWR library into the AWS kinesis streams: https://github.com/daroczig/AWR.Kinesis
#flog.appender(appender.kinesis_handler('logging_data','us-east-2','LOL'), 'kinesis')