Skip to content

Conversation

@wesnest
Copy link

@wesnest wesnest commented Jul 19, 2018

added code to pipeline data with AWR library into the AWS kinesis streams: https://github.com/daroczig/AWR.Kinesis

#flog.appender(appender.kinesis_handler('logging_data','us-east-2','LOL'), 'kinesis')

added code to pipeline data with AWR library into the AWS kinesis streams: https://github.com/daroczig/AWR.Kinesis
R/appender.R Outdated
{

function(line) {
library(AWR.Kinesis)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requireNamespace might be more appropriate here? And maybe adding to Suggests in the DESCRIPTION file.

@muxspace
Copy link
Contributor

Hi thanks for the contribution. The appender.kinesis_firehose needs some improvement. The documentation parameters don't match the function parameters. Also, where does the variable RFIREHOSE come from? Is that a global variable defined by AWR.kinesis?

@daroczig
Copy link
Contributor

daroczig commented Sep 15, 2019

As the author and maintainer of AWR.Kinesis, I'd not suggest using it from now on as there is a much better alternative -- disclaimer: I am the maintainer of that as well ... To keep it short, it's not using Java in the background, but Python and is much more stable and flexible (especially when using in forked processes): daroczig/botor#5

Note that it has been also added to logger and can be called as an async logger (delivering log records in a couple ms): https://github.com/daroczig/logger/pull/35/files#diff-76fdbeebe6348876a783c232ea263683R161

To keep it short, I'd suggest reworking this PR to use the botor package as implemented for logger,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants