Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4468 +/- ##
==========================================
- Coverage 94.69% 94.68% -0.01%
==========================================
Files 94 94
Lines 13597 13596 -1
==========================================
- Hits 12875 12874 -1
Misses 722 722
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #2451.
MemoryStore preserves
foo/barwhen asked to delete the nonexistent keyfoo.LocalStore can instead remove the objects beneath that prefix. A request to
delete one nonexistent key should not delete several other objects. The
maintainer distinguished single-key
deletefrom recursivedelete_dirin#2451; #2606 documented the existing behavior without fixing it.
This change makes directory prefixes a no-op for LocalStore's
deleteanddelete_sync. Actual file deletion is unchanged. Callers relying on recursivedeletion must use
delete_dir, orclearfor the whole store.For reviewers
The compatibility change is intentional. The old recursive-directory test is
replaced, the docstring and changelog explain migration, and an API test that
used root
delete()for cleanup now usesdelete_dir(). No public API ordependency is added.
The 12 regression cases check complete key lists and bytes for directory/root
prefixes, plus file deletion, missing keys, explicit recursive deletion and
read-only protection. They give 8 failures and 4 passes on main, and all pass
with the fix. Selected store, group, array and API modules report 4642 passed
and 1134 skipped. Ruff, formatting, numpydoc and changelog checks pass. Mypy
reports the same 9 optional-obstore unused-ignore errors on main. File and
missing-key deletion medians increased by 2.4 and 0.7 microseconds in local
microbenchmarks. Actual symlink probes were skipped for Windows privileges.
Codex implemented the change and tests, ran the local checks, and helped
translate and organize this description; a separate Codex agent reviewed
the change. I have reviewed and understand the changes.
Author attestation
TODO
changes/.