Skip to content

Conversation

@dstansby
Copy link
Contributor

@dstansby dstansby commented Jun 19, 2024

Fixes #521.

Currently the solution is to just test without zfpy support, which is easy to implement. In an ideaL world I guess we want to run at least one test with zfpy and numpy<2? I won't have time to implement that in the next few days, so someone else feel free to take over and do that if desirable.

@dstansby dstansby marked this pull request as draft June 19, 2024 09:22
@rgommers rgommers mentioned this pull request Jun 19, 2024
@dstansby dstansby marked this pull request as ready for review June 19, 2024 18:50
Copy link
Member

@normanrz normanrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this it a good solution. I will merge tomorrow if there are no objections.

We should track numpy 2.0 support in zfpy, though.

@dstansby
Copy link
Contributor Author

dstansby commented Jun 20, 2024

I updated this so the Python 3.10 tests use numpy<2 and zfpy, so hopefully we still get the zfpy tests running.

@normanrz normanrz merged commit 485224f into zarr-developers:main Jun 20, 2024
@dstansby dstansby deleted the numpy-2 branch June 20, 2024 20:10
@normanrz normanrz mentioned this pull request Jul 1, 2024
7 tasks
DimitriPapadopoulos pushed a commit to DimitriPapadopoulos/numcodecs that referenced this pull request Aug 10, 2024
@codecov
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (5f13152) to head (05b9edf).
Report is 29 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #535   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files          59       59           
  Lines        2318     2318           
=======================================
  Hits         2316     2316           
  Misses          2        2           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NumPy 2.0 support

2 participants