Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RDP #46

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add RDP #46

wants to merge 2 commits into from

Conversation

DaniilKl
Copy link
Contributor

Copied from one of our internal projects. @m-iwanicki, sorry for copying your changes, but I really don't want to lose them.

@DaniilKl DaniilKl changed the base branch from main to develop December 13, 2024 15:36
@DaniilKl DaniilKl changed the title Add rdp Add RDP Dec 13, 2024
@DaniilKl
Copy link
Contributor Author

This is a WIP PR, and if smbd wants to contribute here - feel free to take over this PR, because I do not have time to finish it currently.

@DaniilKl DaniilKl linked an issue Dec 13, 2024 that may be closed by this pull request
Copy link
Contributor

@m-iwanicki m-iwanicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DaniilKl no problem

Comment on lines 6 to 13
openssl genrsa -out cakey.pem 2048
openssl req -new -x509 -nodes -days 365000 -key cakey.pem -out cacert.pem -subj "/CN=rdp"
openssl genrsa -out tls.key 2048
openssl req -new -key tls.key -out tls.csr -subj "/CN=rdp"
openssl x509 -req -days 365 -in tls.csr -out tls.crt -CA cacert.pem -CAkey cakey.pem
install -d "${D}${TLS_DIR}"
install -m 0644 tls.crt "${D}${TLS_DIR}/tls.crt"
install -m 0644 tls.key "${D}${TLS_DIR}/tls.key"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's only for debug/developer images but it'd probably be better if we generated keys on first boot.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ce7b522: keys are generated only on first boot

@m-iwanicki
Copy link
Contributor

@DaniilKl Added key generation on first boot and changed most dbg overrides to use packageconfig so it's enough to PACKAGECONFIG:remove = "rdp" in bbappend of higher priority to disable those changes. Tested on QEMU.
I think this PR is ready for review.

@m-iwanicki m-iwanicki marked this pull request as ready for review January 21, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RDP
2 participants