Migrate JSON serialization to Jackson #344
Conversation
|
Fixed Issues (1)Great job! The following issues were fixed in this Pull Request
Use @Checkmarx to reach out to us for assistance. Just send a PR comment with Examples: |
thc202
changed the title
|
YAML was already using Jackson, please, update commit/PR messages accordingly. |
| implementation("com.fasterxml.jackson.core:jackson-annotations") | ||
| implementation("com.fasterxml.jackson.dataformat:jackson-dataformat-yaml") | ||
|
|
||
| implementation("io.github.classgraph:classgraph:4.8.184") |
There was a problem hiding this comment.
Do not introduce unnecessary runtime dependencies.
There was a problem hiding this comment.
These dependencies are required for the following purposes:
com.fasterxml.jackson.core:jackson-annotations:
Used insrc/main/java/org/zaproxy/zest/core/v1/ZestCookie.java,src/main/java/org/zaproxy/zest/core/v1/ZestLoopTokenFileSet.java,src/main/java/org/zaproxy/zest/core/v1/ZestResponse.java, andsrc/main/java/org/zaproxy/zest/impl/jackson/JacksonConfig.javaio.github.classgraph:classgraph:
Look up subtypes of theZestElementclass and register them as subtypes for Jackson polymorphic type handling.
Used insrc/main/java/org/zaproxy/zest/impl/jackson/JacksonConfig.java.
There was a problem hiding this comment.
Note where the review comment is added. I'm talking about a single dependency, and no, it's not necessary to scan the classpath at runtime.
|
Next time ask before working on assigned issues, avoids duplicating others time. |
Umoxfo
force-pushed
the
jackson
branch
3 times, most recently
from
b8bcc5f to
2254098
Compare
|
Please, update the changelog as well. |
Replaces Gson with Jackson for JSON serialization in Zest core classes. * Introducing custom configuration for type handling, date formatting, and HTML-safe escaping * Adds a new custom Jackson serializer modifier for Zest-specific serialization needs * Updates dependencies * Adapts tests and constructors for Jackson This improves extensibility, consistency, and future maintainability of serialization logic. Signed-off-by: Umoxfo <[email protected]>
Done. b0171a2 |
3 participants
Replaces Gson with Jackson for JSON serialization in Zest core classes.
This improves extensibility, consistency, and future maintainability of serialization logic.
Fix #253