[C++][Compute] Tighten if_else exact dispatch for parameterized value types#79
Draft
zanmato1984 wants to merge 1 commit into
Draft
[C++][Compute] Tighten if_else exact dispatch for parameterized value types#79zanmato1984 wants to merge 1 commit into
zanmato1984 wants to merge 1 commit into
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if_elseexact dispatch so the value operands must fully match asDataTypes before an exact kernel can be selectedDispatchBestresponsible for decimal normalization / cast insertion instead of letting broadtype_idmatches short-circuit that pathRoot cause
if_elseregistered several exact kernels with signatures that only matched the value operands bytype_id(for example decimals, fixed-size binary, nested, dictionary, and timestamp unit matchers). That let exact dispatch succeed for parameterized value types that were not actually type-equal, which could bypass the normalization and cast-insertion logic that lives inDispatchBestand expression binding.What changed
MatchConstraintforif_elsekernels that requiresthenandelseto have the same fullDataTypeduring exact dispatchif_elsekernels so exact dispatch no longer accepts broader parameterized matchesDispatchBestand expression binding tests to confirm the cast path still runs when exact dispatch is rejectedValidation
./build/debug/arrow-compute-scalar-if-else-test --gtest_filter=TestIfElseKernel.IfElseDispatchBest:TestIfElseKernel.IfElseDispatchExact./build/debug/arrow-compute-expression-test --gtest_filter=Expression.BindWithImplicitCastsForIfElseOnDecimal