[C++][Compute] Normalize decimal value arguments in choose DispatchBest#78
Draft
zanmato1984 wants to merge 1 commit into
Draft
[C++][Compute] Normalize decimal value arguments in choose DispatchBest#78zanmato1984 wants to merge 1 commit into
zanmato1984 wants to merge 1 commit into
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chooseDispatchBestafter index promotionchooseexact matches to already share the same decimal type so binding falls back toDispatchBestwhen rescaling is neededchoosecallsRoot cause
choosewas missing the decimal normalization step thatif_else,case_when, andcoalescealready apply on their best-dispatch path. Separately, the decimal varargs kernels forchoosewere permissive enough to satisfy exact dispatch for mixed-scale decimal arguments, which let expression binding bypassDispatchBestentirely and keep mismatched decimal value types.What changed
After promoting the index argument to
int64,ChooseFunction::DispatchBestnow runs decimal normalization across the value arguments before selecting the kernel. The decimalchoosekernels also now carry a match constraint that only allows exact dispatch when all decimal value arguments already have the same type, so expression binding inserts the expected casts instead of short-circuiting.Testing
arrow-compute-expression-test --gtest_filter='Expression.BindWithImplicitCastsForChooseOnDecimal'arrow-compute-scalar-if-else-test --gtest_filter='TestChooseKernel.DispatchBest'arrow-compute-scalar-if-else-test --gtest_filter='TestChoose.*:TestChooseKernel.*'