Skip to content

[C++][Compute] Add decimal dispatch regression tests#77

Draft
zanmato1984 wants to merge 1 commit into
codex/if-else-match-constraintfrom
codex/match-constraint-test-cases
Draft

[C++][Compute] Add decimal dispatch regression tests#77
zanmato1984 wants to merge 1 commit into
codex/if-else-match-constraintfrom
codex/match-constraint-test-cases

Conversation

@zanmato1984

@zanmato1984 zanmato1984 commented Jun 5, 2026

Copy link
Copy Markdown
Owner

Adds focused regression/validation cases for decimal dispatch behavior around match constraints and expression binding.

What changed:

  • Adds expression bind cases for decimal if_else, coalesce, and choose.
  • Adds dispatch-level decimal cases for coalesce and choose.

Baseline:

  • This PR targets codex/if-else-match-constraint inside the fork repo so the diff only contains the test cases, not the existing match-constraint implementation.

Validation:

  • git diff --check passes.
  • .build-choose-test/release/arrow-compute-expression-test --gtest_filter=Expression.BindWithImplicitCastsForIfElseOnDecimal:Expression.BindWithImplicitCastsForCoalesceOnDecimal:Expression.BindWithImplicitCastsForChooseOnDecimal currently has 1 pass and 2 expected failures: coalesce and choose expression binding do not insert the decimal cast.
  • .build-choose-test/release/arrow-compute-scalar-if-else-test --gtest_filter=TestCoalesce.DispatchBest:TestChooseKernel.DispatchBest currently has 1 pass and 1 expected failure: choose DispatchBest does not normalize decimal value args yet.

@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant