Draft: final diff for PR 72 against main#73
Draft
zanmato1984 wants to merge 25 commits into
Draft
Conversation
Co-authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
This reverts commit db970f1e89722dcf65b09553c51ed1b1a4ede3ce.
Introduce SelectionSpan (ContiguousSpan / FilteredSpan / DiscreteSpan) for the scalar kernel selective_exec API. Currently ExecSpanIterator only emits DiscreteSpan, but VisitSelectionSpanInline allows kernels and tests to handle additional shapes incrementally. Also cast SelectionVector indices to int64 in the dense gather/execute/scatter fallback since Scatter requires signed indices.
Remove SelectionVectorSpan, use DiscreteSpan directly, emit ContiguousSpan for contiguous selections, and simplify VisitSelectionSpanInline with overload visitors.
- Hide selection backend behind PIMPL (indices/mask/ranges) - Use backend-specific gather/scatter for selective dense fallback - Normalize preallocation state + fix tests
This reverts commit 9a9fbf1.
- Deduplicate ApplySelectionMask for ArrayData/ArraySpan\n- Fix OUTPUT_NOT_NULL full-span validity init\n- Add unit test for OUTPUT_NOT_NULL selective exec
- Centralize SelectedCount/empty-span checks\n- Reduce scattered selection if/else in ScalarExecutor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helper PR for reviewing the final combined diff.
This compares
draft/selection-spandirectly againstmain, so it includes both:fix/gh-47376)draft/selection-span)This is intended for diff inspection only. Please review/merge the stacked PRs separately.