fix(gpu): add indexes to modulus switch noise reduction #2331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillermo-oyarzun
force-pushed
the
go/fix/add-indexes-to-noise-reduction-key
branch
2 times, most recently
from
8376f94 to
ac3c04f
Compare
agnesLeroy
reviewed
May 14, 2025
There was a problem hiding this comment.
Hey @guillermo-oyarzun! Thanks a lot for this PR, here are a few minor comments
backends/tfhe-cuda-backend/cuda/src/pbs/programmable_bootstrap_classic.cu
Show resolved
Hide resolved
tfhe/src/core_crypto/gpu/algorithms/test/modulus_switch_noise_reduction.rs
Outdated
Show resolved
Hide resolved
guillermo-oyarzun
force-pushed
the
go/fix/add-indexes-to-noise-reduction-key
branch
from
ac3c04f to
8206220
Compare
guillermo-oyarzun
force-pushed
the
go/fix/add-indexes-to-noise-reduction-key
branch
2 times, most recently
from
250f065 to
a8fbf1d
Compare
bbarbakadze
requested changes
May 14, 2025
guillermo-oyarzun
force-pushed
the
go/fix/add-indexes-to-noise-reduction-key
branch
from
a8fbf1d to
b19e23a
Compare
agnesLeroy
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: please link all relevant issues
PR content/description
Check-list: