Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

GH #47: Proposal how to avoid exception logging. #89

Merged
merged 1 commit into from
Jul 17, 2018

Conversation

vadeg
Copy link
Contributor

@vadeg vadeg commented Jun 11, 2017

Fix for #47.

  • Added additional check if property or ENV variableCREDENTIALS_DIR exists or not without throwing exception.
  • AccessTokensBuilder code refactored. Now exception is not thrown during build if there is no CREDENTIALS_DIR.
  • Added test for testing that AccessTokensBuilder receives correct AbstractAccessTokenRefresher

No "CREDENTIALS_DIR" exception if it is not configured.
@codecov-io
Copy link

codecov-io commented Jun 11, 2017

Codecov Report

Merging #89 into master will decrease coverage by 0.08%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #89      +/-   ##
============================================
- Coverage     72.05%   71.97%   -0.09%     
- Complexity      239      241       +2     
============================================
  Files            48       48              
  Lines           841      842       +1     
  Branches         40       40              
============================================
  Hits            606      606              
  Misses          213      213              
- Partials         22       23       +1
Impacted Files Coverage Δ Complexity Δ
...in/java/org/zalando/stups/tokens/FileSupplier.java 93.75% <80%> (-0.37%) 7 <3> (+1)
.../org/zalando/stups/tokens/AccessTokensBuilder.java 73.43% <85.71%> (-0.38%) 43 <8> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eecc0e6...651257a. Read the comment docs.

@jbellmann
Copy link
Contributor

@vadeg I like it. Thanks for your contributions.

@jbellmann jbellmann merged commit 651257a into zalando:master Jul 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants