Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Spring to 6.2 #1682

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

yuppie-flu
Copy link
Member

Description

This PR updates Spring Framework version to 6.2.1 and replaces removed (deprecated) APIs to alternatives:

  • removed AbstractClientHttpResponse abstract class was replaced to ClientHttpResponse interface

In Spring Framework 6.2 org.springframework.http.HttpRequest interface received a new method: Map<String, Object> getAttributes() without a default implementation. The PR doesn't implement the method and throw UnsupportedOperationException instead. It seems that this method is needed only for very rare use cases (like passing attributes to interceptors, see spring-projects/spring-framework#32027). However, we can discuss if some implementation in Riptide makes sense.

Motivation and Context

In Spring Framework 6.2 release several deprecated APIs were removed. The current Riptide code uses some of them, in particular: org.springframework.http.client.AbstractClientHttpResponse.
The newest Spring Boot 3.4 release uses Spring Framework 6.2. The incompatibility of the current Riptide with Spring Framework 6.2 makes it impossible to upgrade services that use Riptide to the latest Spring Boot. ClassNotFoundException about AbstractClientHttpResponse is thrown at runtime.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [?] My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@fatroom fatroom added the major Major feature changes or updates, e.g. feature rollout to a new country, new API calls. label Jan 6, 2025
@yuppie-flu yuppie-flu marked this pull request as ready for review January 7, 2025 08:56
@fatroom
Copy link
Member

fatroom commented Jan 7, 2025

👍

1 similar comment
@yuppie-flu
Copy link
Member Author

👍

@fatroom fatroom merged commit e59f2e9 into zalando:main Jan 7, 2025
4 checks passed
@yuppie-flu yuppie-flu deleted the update-spring-to-6.2 branch January 7, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Major feature changes or updates, e.g. feature rollout to a new country, new API calls.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants