Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates Spring Framework version to 6.2.1 and replaces removed (deprecated) APIs to alternatives:
AbstractClientHttpResponse
abstract class was replaced toClientHttpResponse
interfaceIn Spring Framework 6.2
org.springframework.http.HttpRequest
interface received a new method:Map<String, Object> getAttributes()
without a default implementation. The PR doesn't implement the method and throw UnsupportedOperationException instead. It seems that this method is needed only for very rare use cases (like passing attributes to interceptors, see spring-projects/spring-framework#32027). However, we can discuss if some implementation in Riptide makes sense.Motivation and Context
In Spring Framework 6.2 release several deprecated APIs were removed. The current Riptide code uses some of them, in particular:
org.springframework.http.client.AbstractClientHttpResponse
.The newest Spring Boot 3.4 release uses Spring Framework 6.2. The incompatibility of the current Riptide with Spring Framework 6.2 makes it impossible to upgrade services that use Riptide to the latest Spring Boot. ClassNotFoundException about
AbstractClientHttpResponse
is thrown at runtime.Types of changes
Checklist: