Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: using react-resizable-panels for activity panels #908

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

stropitek
Copy link
Contributor

@stropitek stropitek commented Mar 27, 2025

No description provided.

@stropitek stropitek linked an issue Mar 27, 2025 that may be closed by this pull request
Copy link

cloudflare-workers-and-pages bot commented Mar 27, 2025

Deploying react-science with  Cloudflare Pages  Cloudflare Pages

Latest commit: f0be481
Status: ✅  Deploy successful!
Preview URL: https://3ff1cc48.react-science.pages.dev
Branch Preview URL: https://905-update-activity-panels-s.react-science.pages.dev

View logs

@stropitek stropitek force-pushed the 905-update-activity-panels-story-to-use-react-resizable-panels branch from 9369b3f to 9ec0578 Compare March 27, 2025 16:54
@stropitek
Copy link
Contributor Author

POC done in story.

We can think of how to integrate this deeper in the API later.

@stropitek stropitek requested a review from targos March 28, 2025 08:17
@stropitek stropitek marked this pull request as draft April 1, 2025 14:30
@stropitek
Copy link
Contributor Author

It's not easy to initialize the sizes properly when a panel is added / removed, and we have a configuration of visible panels that we have never seen before.

The default is to split them evenly but this is not what we want. We'd rather have them take space that is a function of the previous configuration but recalculated with one panel more / less.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update activity panels story to use react-resizable-panels
1 participant