Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to search with yes or no #850

Merged
merged 1 commit into from
Jan 3, 2025
+9 −4
Merged

fix: allow to search with yes or no #850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/components/info-panel/InfoPanel.tsx
View file
Original file line number Diff line number Diff line change
@@ -109,9 +109,9 @@ export function InfoPanel(props: InfoPanelProps) {
const includes: InfoPanelDatum[] = [];
const valueContains: InfoPanelDatum[] = [];

for (const [parameter, value] of Object.entries(data).sort(([a], [b]) =>
a.localeCompare(b),
)) {
for (const [parameter, value] of Object.entries(data).sort(([a], [b]) => {
return a.localeCompare(b);
})) {
const lowerKey = parameter.toLowerCase();
const lowerSearch = search.toLowerCase();
if (lowerKey === lowerSearch) {
@@ -277,7 +277,12 @@ function valueSearch(
return match(value)
.with(P.boolean, (value) => String(value).includes(search))
.with(P.number, (value) => String(value).includes(search))
.with(P.string, (value) => value.includes(search))
.with(P.string, (value) => {
const newValue =
value === 'true' ? 'yes' : value === 'false' ? 'no' : value;

return newValue.includes(search);
})
.with({}, (value) => JSON.stringify(value).includes(search))
.otherwise(() => true);
}

Unchanged files with check annotations Beta

View file
src/app-data/loaders/biologicLoader.ts
for (const file of fileCollection.files) {
try {
if (/\.mpr$/i.test(file.name)) {
// TODO: load in parallel

Check warning on line 29 in src/app-data/loaders/biologicLoader.ts

GitHub Actions / nodejs / lint-eslint 

Unexpected 'todo' comment: 'TODO: load in parallel'
// eslint-disable-next-line no-await-in-loop
const mpr = parseMPR(await file.arrayBuffer());
const meta = mpr.settings.variables;
};
entries.push(result);
} else if (/\.mpt$/i.test(file.name)) {
// TODO: load in parallel

Check warning on line 46 in src/app-data/loaders/biologicLoader.ts

GitHub Actions / nodejs / lint-eslint 

Unexpected 'todo' comment: 'TODO: load in parallel'
// eslint-disable-next-line no-await-in-loop
const { data, settings } = parseMPT(await file.arrayBuffer());
if (data.variables) {
View file
src/app-data/loaders/cdfLoader.ts
for (const file of fileCollection) {
if (/\.cdf$/i.test(file.name)) {
try {
// TODO: load in parallel

Check warning on line 24 in src/app-data/loaders/cdfLoader.ts

GitHub Actions / nodejs / lint-eslint 

Unexpected 'todo' comment: 'TODO: load in parallel'
// eslint-disable-next-line no-await-in-loop
const reader = new NetCDFReader(await file.arrayBuffer());
View file
src/app-data/loaders/jcampLoader.ts
for (const file of fileCollection) {
if (/(?:\.jdx|\.dx)$/i.test(file.name)) {
try {
// TODO: load in parallel

Check warning on line 25 in src/app-data/loaders/jcampLoader.ts

GitHub Actions / nodejs / lint-eslint 

Unexpected 'todo' comment: 'TODO: load in parallel'
// eslint-disable-next-line no-await-in-loop
const parsed = convert(await file.text(), { keepRecordsRegExp: /.*/ });
for (const measurement of parsed.flatten) {
return newMeasurements;
}
function normalizeSpectra(spectra: any) {

Check warning on line 75 in src/app-data/loaders/jcampLoader.ts

GitHub Actions / nodejs / lint-eslint 

Unexpected any. Specify a different type
const data: any[] = [];

Check warning on line 76 in src/app-data/loaders/jcampLoader.ts

GitHub Actions / nodejs / lint-eslint 

Unexpected any. Specify a different type
for (const spectrum of spectra) {
let variables = spectrum.variables;
if (!variables) {
View file
src/app-data/loaders/loadMeasurements.ts
const logs: ParserLog[] = [];
const { loaders = [], enhancers = {}, logger } = options;
for (const loader of loaders) {
// TODO: load in parallel

Check warning on line 25 in src/app-data/loaders/loadMeasurements.ts

GitHub Actions / nodejs / lint-eslint 

Unexpected 'todo' comment: 'TODO: load in parallel'
// eslint-disable-next-line no-await-in-loop
const loaderData = await loader(fileCollection, logger);
for (const { entries } of Object.values(loaderData)) {
for (const datum of measurement.data) {
for (const variable of Object.values(datum.variables)) {
if (variable.data.length === 0) {
// TODO: should we accept empty data?

Check warning on line 43 in src/app-data/loaders/loadMeasurements.ts

GitHub Actions / nodejs / lint-eslint 

Unexpected 'todo' comment: 'TODO: should we accept empty data?'
return;
}
if (variable.min === undefined || variable.max === undefined) {
View file
src/app-data/loaders/proprietary/agilent/cary500Loader.ts
for (const file of fileCollection) {
if (/\.csv$/i.test(file.name)) {
try {
// TODO: load in parallel

Check warning on line 17 in src/app-data/loaders/proprietary/agilent/cary500Loader.ts

GitHub Actions / nodejs / lint-eslint 

Unexpected 'todo' comment: 'TODO: load in parallel'
// eslint-disable-next-line no-await-in-loop
const experiments = await convert(file);
for (const experiment of experiments) {
View file
src/app-data/loaders/spcLoader.ts
for (const file of fileCollection) {
if (/\.spc$/i.test(file.name)) {
try {
// TODO: load in parallel

Check warning on line 28 in src/app-data/loaders/spcLoader.ts

GitHub Actions / nodejs / lint-eslint 

Unexpected 'todo' comment: 'TODO: load in parallel'
// eslint-disable-next-line no-await-in-loop
const parsed = parse(await file.arrayBuffer());
const spectraType: MeasurementKind = guessSpectraType(parsed.meta);