Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nmr story #363

Closed

Conversation

wadjih-bencheikh18
Copy link
Contributor

closes : #362

@netlify
Copy link

netlify bot commented Mar 6, 2022

✔️ Deploy Preview for react-plot ready!

🔨 Explore the source changes: a91dc87

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-plot/deploys/622473b604d64500086726e7

😎 Browse the preview: https://deploy-preview-363--react-plot.netlify.app

@wadjih-bencheikh18
Copy link
Contributor Author

@targos i think optmise data is the only solution to make it render fast (d3 line generator take time to calculate)
as mentioned here #316

@wadjih-bencheikh18
Copy link
Contributor Author

in https://blog.scottlogic.com/2020/05/01/rendering-one-million-points-with-d3.html
they mention that : "SVG charts can handle around 1,000 datapoints"

i'm not sure if there is a way to optmise scripting here

@targos
Copy link
Member

targos commented Mar 18, 2022

Yeah I agree this has to be fixed by reducing the number of points in the SVG (#316)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash with NMR story book
2 participants