feat: Add podAnnotations for deployment #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zakkg3 Please review |
|
Any updates with it ? |
|
I have to fix the e2e test and if that passes ill merge this. I guess in the next days I hope I find the time for this. |
Super good. Thank you. |
|
thanks for the pr. |
|
BTW the e2e test are failing cause the was some changes on the chart without bumping the chart version. will fix this all on the fix-all pr |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for customizable pod annotations in the deployment.yaml and values.yaml files.
podAnnotationsfield in values.yaml to allow users to define custom annotations for pods.endstatement in tolerations block for cleaner YAML structure.