feat(core,dom): rename recipe → Pattern — phase 4 (internal helper surface)#1066
Merged
Merged
Conversation
…urface) Completes the recipe -> Pattern rename on the JS side: the remaining recipe-named EXPORTED helpers become Pattern-named, each with a @deprecated alias of the old name (removed at 1.0) so nothing breaks: - types: BodyPattern, RelationshipPattern, AccessibilityPattern, PatternTier, PatternStatus, PatternProblem, PatternTierGroup, PatternRenderPlan, Pattern{Body,Relationship}Registration, PatternFeedbackBinding, PatternReducedMotionPlan, PatternAuthoring, PatternFieldTarget (dom) - consts: PATTERN_TIERS, PATTERN_CONTRACTS - fns: validatePattern, serializePattern, patternById, patternBodyAttributes, patternRenderPlan, patternToMarkup, patternAuthoring - bindData gains a option (recipe read as a deprecated fallback) Intentionally unchanged (invisible plumbing, not concept surface): the recipes/ source folder, apply-recipe.ts, data/recipes.json, and the RelationshipSource 'recipe' value tag. Verified: core build + 930 tests, dom 171 tests, check:api / check:docs / check:recipes green.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e3aa8d7653
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /** @deprecated Renamed to {@link PatternStatus}. */ export type RecipeStatus = PatternStatus; | ||
| /** @deprecated Renamed to {@link PatternProblem}. */ export type RecipeProblem = PatternProblem; | ||
| /** @deprecated Renamed to {@link validatePattern}. */ export const validateRecipe = validatePattern; | ||
| /** @deprecated Renamed to {@link serializePattern}. */ export const serializeRecipe = serializePattern; |
There was a problem hiding this comment.
With serializePattern now exported as the canonical name, the JSON round-trip path still cannot be written using Pattern names because this alias block leaves parseRecipe as the only parser export. Callers migrating off deprecated recipe terminology must import parseRecipe for parseRecipe(serializePattern(...)), so the additive rename is incomplete for this helper surface.
Useful? React with 👍 / 👎.
zachshallbetter
added a commit
that referenced
this pull request
Jul 10, 2026
…ports (phase 4) (#1067) Phase 4 of the recipe -> **Pattern** rename, mirrored to the Swift + Kotlin ports so the whole stack's helper surface reads *Pattern*. Same helper family as the JS side (#1066): `BodyRecipe`->`BodyPattern`, `RecipeProblem`->`PatternProblem`, `validateRecipe`->`validatePattern`, the registrations, etc. **Clean rename, no deprecation aliases** — the ports have no external consumers (0.x preview), so nothing needs the old names (the JS packages keep aliases because the site imports them). Internal refs all migrated. Verified: `swift build` + `swift test` (**234 tests** incl. the cross-plane conformance golden) and Kotlin `:fundamental-core:test :lab:test` (**217 tests**) green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 4 of the recipe → Pattern rename — the JS internal-helper surface, so the whole JS API reads Pattern.
The remaining recipe-named exported helpers are renamed to Pattern, each with a
@deprecatedalias of the old name (removed at 1.0). Types (BodyPattern,PatternTier,AccessibilityPattern, the registrations, …), consts (PATTERN_TIERS,PATTERN_CONTRACTS), functions (validatePattern,serializePattern,patternById, …), andbindDatagains apatternoption (therecipeoption is read as a deprecated fallback). Every old name still works — purely additive.Intentionally unchanged (invisible plumbing, not concept surface): the
recipes/source folder,apply-recipe.ts,data/recipes.json, and theRelationshipSource'recipe'value tag.Verified: core build + 930 tests, dom 171 tests,
check:api/check:docs/check:recipesgreen. Ports mirror + site + docs prose follow in separate PRs.