-
Notifications
You must be signed in to change notification settings - Fork 16
ci: add initial GitHub Actions integration #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Aww thanks, I wasn't expecting someone else to do this! |
|
:3 |
|
This currently only runs tests on Linux. It should probably test MacOS as well, but I’m not certain about the dependency installation process over there. I’ll try it out in a different branch and report back if I have any success. EDIT: Update, looks good; pushing here. |
|
Marking this as no longer a draft so that hopefully the checks will actually attempt to run here. I’m not sure why the checks aren’t running on this PR itself. They’re running on my branch. Also, I need to force-push an update to the last commit, ‘linux’ is no longer accurate as a job name. |
As we support MacOS, we should additionally run tests on MacOS in CI
Overall the backups are working fine, so all this commit does it update blessed values and add some additional tests. First, this should never have gotten to master for more than a day. There is an ongoing PR #64 to add continuous integration, so that if tests fail we are immediately alerted. (and for PRs, we know if tests pass before merging) On to the actual reproducibility issues. The first is that the explanatory text changed from "To restore this file from the command line in Linux" to "To restore this file from the command line" The second is that python's gzip module had a reproduciblity regression between 3.10 and 3.11 where one byte differed in output (and generally does not guarantee this will remain identical). See the python bug at python/cpython#112346 for details.
|
Unsure why it wasn't running for you. I just cherry-picked this over and it ran for me. |
|
Added to master as 8d40ed3 (You have been credited as "Summer Tea", let me know if you would prefer another name) Feel free to revise to add working OS X continuous integration support, or to close this PR if you don't want to. |
|
I’m taking a look at the MacOS CI. |
|
I’m getting a Notes so far:
In my current iteration, I added a bunch of off-the-shelf caching to all the dependencies because it was taking a very long time to retry after each failure. This also abstracts away 1. The Linux test still works, so I believe this pillow issue to be MacOS-specific. Also, we probably shouldn’t list Python 3.6 as supported anymore in the install guide; it’s long-EOL and not even available to test in GitHub CI anymore. 3.9 is the oldest non-EOL Python version currently, and |
from the nix packager... hmmm sus (yes this is fine, feel free to bump to 3.9) You probably need to install the font, as listed in the install guide. Unfortunately the listed advice on how to install is "double click the font". Good luck! Edit: That could use a better error message on our end if that's really the problem, but let's focus this PR on just CI. |
Hopefully prevent future regressions such as gh-63.
Closes: gh-62
---
This is currently blocked by gh-63, as we need to fix the tests before we can make sure this works as intended.