Skip to content

Add support for 1.19 component NBT #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for 1.19 component NBT #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 27 additions & 12 deletions src/main/java/fr/zcraft/quartzlib/components/nbt/NBT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,20 +301,30 @@ private static Object getMcNBTCompound(ItemStack item) throws NMSException {
try {
Object tagCompound;
try {
//1.18
tagCompound = Reflection.call(mcItemStack.getClass(), mcItemStack, "t");
// 1.19
tagCompound = Reflection.call(mcItemStack.getClass(), mcItemStack, "getTagClone");
} catch (Exception e) {
//1.17
try {
tagCompound = Reflection.call(mcItemStack.getClass(), mcItemStack, "getTag");
} catch (Exception e2) {
tagCompound = Reflection.call(mcItemStack.getClass(), mcItemStack, "a");
// 1.18
tagCompound = Reflection.call(mcItemStack.getClass(), mcItemStack, "t");
} catch (Exception e1) {
// 1.17
try {
tagCompound = Reflection.call(mcItemStack.getClass(), mcItemStack, "getTag");
} catch (Exception e2) {
tagCompound = Reflection.call(mcItemStack.getClass(), mcItemStack, "a");
}
}
}

if (tagCompound == null) {
tagCompound = Reflection.instantiate(MC_NBT_TAG_COMPOUND);
Reflection.call(MC_ITEM_STACK, mcItemStack, "setTag", tagCompound);
try {
// 1.19
Reflection.call(MC_ITEM_STACK, mcItemStack, "setTagClone", tagCompound);
} catch (Exception e) {
Reflection.call(MC_ITEM_STACK, mcItemStack, "setTag", tagCompound);
}
}
return tagCompound;

Expand All @@ -327,11 +337,16 @@ private static Object getMcNBTCompound(ItemStack item) throws NMSException {
tag = Reflection.instantiate(MC_NBT_TAG_COMPOUND);

try {
Reflection.call(MC_ITEM_STACK, mcItemStack, "setTag", tag);
} catch (NoSuchMethodException e) {
// If the set method change—more resilient,
// as the setTag will only update the field without any kind of callback.
Reflection.setFieldValue(MC_ITEM_STACK, mcItemStack, "tag", tag);
// 1.19
Reflection.call(MC_ITEM_STACK, mcItemStack, "setTagClone", tag);
} catch (Exception e) {
try {
Reflection.call(MC_ITEM_STACK, mcItemStack, "setTag", tag);
} catch (NoSuchMethodException e2) {
// If the set method change—more resilient,
// as the setTag will only update the field without any kind of callback.
Reflection.setFieldValue(MC_ITEM_STACK, mcItemStack, "tag", tag);
}
}
}

Expand Down