Unhook players when they enter Spectator Mode - Fixes #71#124
Open
squeeglii wants to merge 1 commit intoyyon:1.20.xfrom
Open
Unhook players when they enter Spectator Mode - Fixes #71#124squeeglii wants to merge 1 commit intoyyon:1.20.xfrom
squeeglii wants to merge 1 commit intoyyon:1.20.xfrom
Conversation
squeeglii
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says.
I would've implemented it without having to add a parameter to unattach, however, that would've needed mixins due to where Forge triggers the gamemode event. This seems to work though and doesn't break old functionality.
Still a recent fix so it may need more testing buuuuut, it seems to work just fine.