Try to fix ConcurrentModificationException (#107)#115
Open
ForgottenUmbrella wants to merge 1 commit intoyyon:1.19from
Open
Try to fix ConcurrentModificationException (#107)#115ForgottenUmbrella wants to merge 1 commit intoyyon:1.19from
ForgottenUmbrella wants to merge 1 commit intoyyon:1.19from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ItemProperties::registermethod is not-thread safe, potentially leading toConcurrentModificationExceptionbeing thrown on startup. This MR attempts to fix that by enqueuing theClientSetup::onClientSetupmethod, based on a similar issue and fix in another mod.Potentially fixes issue #107. It's hard to test whether the fix actually works because concurrency bugs are a pain to reproduce.