-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update git.py for python3 #448
base: dev
Are you sure you want to change the base?
Conversation
@DedSecer Any progress here? I wouldn't want to merge a git implementation without ssh key support. Not having any Python 2 support is also a bit of a problem, but maybe it's time to thing about a Python-3-only-StaSh soon... |
@fschaeck Sorry,I am busying.Since somebody noticed this, I will trying to process,this could be very slow. |
FUNKY_URL = 'https://github.com/FriendCode/funky/archive/master.zip' | ||
DULWICH_URL = 'https://github.com/jsbain/dulwich/archive/ForStaSH_0.12.2.zip' | ||
REQUIRED_DULWICH_VERSION = (0, 12, 2) | ||
DULWICH_URL = 'https://github.com/dedsecer/dulwich/archive/checkout.zip' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use https://pypi.org/project/dulwich ?
DedSecer/dulwich 3 commits ahead, 545 commits behind jelmer/dulwich
Please rebase. |
This PR still can not work in Pythonista 3.4, Firstly, Pythonista doesn't support Subprocesses, so it cannot support shell hooks for git. #self.hooks["pre-commit"] = PreCommitShellHook(self.controldir())
#self.hooks["commit-msg"] = CommitMsgShellHook(self.controldir())
#self.hooks["post-commit"] = PostCommitShellHook(self.controldir())
#self.hooks["post-receive"] = PostReceiveShellHook(self.controldir()) Then, there is also a small issue in the git.py file of this PR. At function git_ add, when adding files, it check whether they are in the repo index. Doing so will result in the inability to add new files. if True or file.encode() in repo.open_index(): Finally, it works correctly. |
Command
git
for python3. (do not support python2)(Still needs tests)
Directly using dulwich(dulwich is more stronger now) without gittle now. (gittle it not update anymore now)
TODO
git checkout .
andgit add .
git config
git diff
git merge
Known issues