Fixed parsing of extended timestamp in chunk message header type 3 #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that extended timestamps can be used in chunk message header type 3 if it was used in preceding non type 3 chunk. This is defined in RTMP specification in Extended Timestamp section:
You can reproduce the problem using ffmpeg by adding a filter to modify the first PTS to a huge value forcing to use a high timestampDelta:
ffmpeg -re -i ${YOUR_INPUT_FILE} -vf "setpts=PTS+20000/TB" -af "asetpts=PTS+20000/TB" ... your encoding options... -f flv ${YOUR_RTMP_SERVER}
This adds 20000 seconds to the first PTS which is greater than what a non-extended timestamp can support (at most 16777214 milliseconds)